make the reinforcements collection dynamic#7449
Open
Goober5000 wants to merge 2 commits into
Open
Conversation
Goober5000
added
enhancement
As requested by a FREDder who has a plausible situation where more than 32 reinforcements might be handy. :)
Goober5000
force-pushed
the
feature/dynamic_reinforcements
branch
from
0a10c4a to
9ff8bbd
Compare
wookieejedi
reviewed
May 15, 2026
wookieejedi
reviewed
May 15, 2026
| void parse_reinforcement(mission *pm) | ||
| { | ||
| reinforcements *ptr; | ||
| reinforcements reinforcement; |
Member
There was a problem hiding this comment.
With this new vector format, should we add default member initializers to ensure when the optional sections are absent, these are left with indeterminate values:?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by a FREDder who has a plausible situation where more than 32 reinforcements might be handy. :)